Page MenuHomePhabricator
Differential D18000

Update PhrictionContent for modular transactions
ClosedPublic
Actions

Authored by chad on May 23 2017, 3:13 AM.
Tags
None
Referenced Files
F13052067: D18000.id43286.diff
Fri, Apr 19, 6:50 AM
Unknown Object (File)
Tue, Apr 16, 4:45 PM
Unknown Object (File)
Thu, Apr 11, 9:51 AM
Unknown Object (File)
Sun, Apr 7, 12:05 PM
Unknown Object (File)
Sun, Apr 7, 6:23 AM
Unknown Object (File)
Sun, Apr 7, 4:10 AM
Unknown Object (File)
Sun, Apr 7, 2:00 AM
Unknown Object (File)
Sun, Apr 7, 1:06 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T12625: Update Phriction for Modular Transactions
Commits
rP7e822fc94fa3: Update PhrictionContent for modular transactions
Summary

Fixes T12625. Moves TYPE_CONTENT in Phriction over to modular transactions.

Test Plan

Edit some documents.

Diff Detail

Repository
rP Phabricator
Branch
phriction-content-txn (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 17203
Build 23025: Run Core Tests
Build 23024: arc lint + arc unit

Event Timeline

chad created this revision.May 23 2017, 3:13 AM
Herald added a subscriber: Korvin. · View Herald TranscriptMay 23 2017, 3:13 AM
Harbormaster completed remote builds in B17203: Diff 43286.May 23 2017, 3:14 AM
epriestley edited edge metadata.May 23 2017, 6:02 PM

Confused about one thing, see inline?

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
12–25

Why is this OK to remove / being removed?

epriestley added a comment.May 23 2017, 6:03 PM

Also, congratulations on desirable round-numbered change D18000!

chad added inline comments.May 23 2017, 6:07 PM
src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php
12–25

whoops

epriestley added a comment.May 23 2017, 6:10 PM

Macro bythepowerof: BY THE POWER OF CODE REVIEW

chad updated this revision to Diff 43300.May 23 2017, 6:32 PM
  • derpina
Harbormaster completed remote builds in B17212: Diff 43300.May 23 2017, 6:33 PM
chad added a comment.May 23 2017, 6:34 PM

Also I can't seem to trigger "CHANGES TO DOCUMENT CONTENT" into mail, any ideas?

epriestley added a comment.May 23 2017, 6:43 PM

Seems to work for me, maybe daemons just need to be restarted to pick up changes?

Screen Shot 2017-05-23 at 11.42.58 AM.png (710×1 px, 86 KB)

chad added a comment.May 23 2017, 6:44 PM

Works for me

epriestley added a comment.May 23 2017, 6:45 PM

me too (works for me [too])

chad added a comment.May 23 2017, 7:00 PM

So this can be landed?

epriestley accepted this revision.May 23 2017, 7:01 PM
This revision is now accepted and ready to land.May 23 2017, 7:01 PM
Closed by commit rP7e822fc94fa3: Update PhrictionContent for modular transactions (authored by chad, committed by chad). · Explain WhyMay 23 2017, 7:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43286

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/phriction/conduit/PhrictionCreateConduitAPIMethod.php

Loading...
View Options

src/applications/phriction/conduit/PhrictionEditConduitAPIMethod.php

Loading...
View Options

src/applications/phriction/controller/PhrictionEditController.php

Loading...
View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...
View Options

src/applications/phriction/storage/PhrictionTransaction.php

Loading...
View Options

src/applications/phriction/xaction/PhrictionDocumentContentTransaction.php

Loading...
View Options

src/applications/phriction/xaction/PhrictionDocumentMoveToTransaction.php

Loading...
Phabricator · Built by Phacility