[amckinley phabricator]$ echo '{"queryKey": "upcoming"}' | arc call-conduit --conduit-uri http://local.phacility.com/ --conduit-token <snip> countdown.search | json_pp "error" : null, "errorMessage" : null, "response" : { "cursor" : { "order" : null, "before" : null, "limit" : 100, "after" : null }, "maps" : [], "query" : { "queryKey" : "upcoming" }, "data" : [ { "phid" : "PHID-CDWN-nqqj6rv6iyaq5s4nt3z3", "fields" : { "spacePHID" : null, "dateModified" : 1492110524, "title" : "foobar", "epoch" : "1492114080", "policy" : { "view" : "users", "edit" : "users" }, "dateCreated" : 1492110524, "description" : "testing 123" }, "attachments" : [], "type" : "CDWN", "id" : 7 } ] } }

Masterwork)

[amckinley phabricator]$ echo '{"objectIdentifier": "PHID-CDWN-nqqj6rv6iyaq5s4nt3z3", "transactions": [{"type": "name", "value": "Assemble in the barnyard"}]}' | arc call-conduit --conduit-uri http://local.phacility.com/ --conduit-token <snip> countdown.edit | json_pp "response" : { "object" : { "id" : "7", "phid" : "PHID-CDWN-nqqj6rv6iyaq5s4nt3z3" }, "transactions" : [] }, "errorMessage" : null, "error" : null }

Diff Detail

Repository

rP Phabricator

Branch

T12524 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 16452
Build 21898: Run Core Tests
Build 21897: arc lint + arc unit

Event Timeline

amckinley created this revision.Apr 13 2017, 7:18 PM

Herald added a subscriber: Korvin. · View Herald TranscriptApr 13 2017, 7:18 PM

Harbormaster completed remote builds in B16450: Diff 42519.Apr 13 2017, 7:20 PM

epriestley accepted this revision.Apr 13 2017, 7:30 PM

epriestley added inline comments.

src/applications/countdown/storage/PhabricatorCountdown.php
175	Add a specification for `epoch` here too (for now, this is only used to generate documentation).
181	For remarkup fields like this, I started doing something to try to future-proof them recently in D17603: Annotate the type as `remarkup`. Return a dictionary with the raw value in `'raw'`. See also discussion in T12461. But the idea is that we might eventually want to be able to return text/html for these fields, or store other flavors of markdown, and we can do that without breaking the API if we emit a dictionary. So the output is currently: "description": "asdf" ...but for consistency with the new scheme in D17603, should be: "description": { "raw": "asdf" }
182	Put an `(int)` cast on this so it emits into JSON as a number instead of a string (PHP is all loosey-goosey about this stuff and we currently don't try to enforce types when they come out of the database). That is, the output currently shows: "epoch": "19831981098" ...but better is: "epoch": 19831981098 ...so that languages which care more will have an easier time interacting with the API.