Touch up Badges emails
ClosedPublic
Actions

Authored by chad on Mar 2 2017, 3:21 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 16, 9:17 PM

	Unknown Object (File)
	Thu, Apr 11, 10:44 AM

	Unknown Object (File)
	Mon, Apr 8, 1:52 AM

	Unknown Object (File)
	Fri, Apr 5, 11:17 PM

	Unknown Object (File)
	Fri, Mar 29, 7:38 AM

	Unknown Object (File)
	Fri, Mar 29, 4:09 AM

	Unknown Object (File)
	Thu, Mar 28, 6:21 PM

	Unknown Object (File)
	Wed, Mar 27, 5:37 PM

View All 80 Files

Subscribers

Korvin

Details

Reviewers

epriestley

Maniphest Tasks

T12270: Unbeta Badges

Commits

rP664d9fa3ed4c: Touch up Badges emails

Summary

Ref T12270. Adds the name of the badge to the subject, fixes the double description.

Test Plan

Edit lots of badges with and without descriptions, see good emails.

Diff Detail

Repository

rP Phabricator

Branch

badges-mail (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15852
Build 20980: Run Core Tests
Build 20979: arc lint + arc unit

Event Timeline

chad created this revision.Mar 2 2017, 3:21 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMar 2 2017, 3:21 AM

Harbormaster completed remote builds in B15852: Diff 41948.Mar 2 2017, 3:22 AM

epriestley accepted this revision.Mar 2 2017, 11:57 AM

This revision is now accepted and ready to land.Mar 2 2017, 11:57 AM

Closed by commit rP664d9fa3ed4c: Touch up Badges emails (authored by chad, committed by chad). · Explain WhyMar 2 2017, 2:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

editor/

PhabricatorBadgesEditor.php

15 lines

Diff 41948

View Options

src/applications/badges/editor/PhabricatorBadgesEditor.php

Touch up Badges emailsClosedPublicActions