Don't link "Dxxx" on Differential revision pages
ClosedPublic
Actions

Authored by epriestley on Feb 1 2017, 2:53 AM.

Tags

None

Referenced Files

	F13045703: D17283.id.diff
	Thu, Apr 18, 2:23 AM

	F13044371: D17283.diff
	Wed, Apr 17, 3:17 PM

	Unknown Object (File)
	Tue, Apr 16, 8:00 PM

	Unknown Object (File)
	Sun, Apr 7, 12:41 PM

	Unknown Object (File)
	Fri, Mar 29, 1:28 AM

	Unknown Object (File)
	Thu, Mar 28, 8:44 PM

	Unknown Object (File)
	Feb 20 2024, 12:31 PM

	Unknown Object (File)
	Feb 20 2024, 11:58 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision"

Commits

rP9b92e56dfc03: Don't link "Dxxx" on Differential revision pages

Summary

Ref T12027. See T12043 for discussion.

Test Plan

Double-clicked "Dxxx" to select it.

Diff Detail

Repository

rP Phabricator

Branch

link1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 15475
Build 20395: Run Core Tests
Build 20394: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 1 2017, 2:53 AM

chad accepted this revision.Feb 1 2017, 2:53 AM

This revision is now accepted and ready to land.Feb 1 2017, 2:53 AM

Harbormaster completed remote builds in B15475: Diff 41577.Feb 1 2017, 2:54 AM

epriestley mentioned this in T12027: Replace "Next Step" Differential advice with comprehensive instructions on "Land Revision".Feb 1 2017, 2:54 AM

Closed by commit rP9b92e56dfc03: Don't link "Dxxx" on Differential revision pages (authored by epriestley, committed by epriestley). · Explain WhyFeb 1 2017, 2:55 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialRevisionViewController.php

2 lines

Diff 41577

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Don't link "Dxxx" on Differential revision pagesClosedPublicActions