Ref T12089. This reverts back to using "bright" colors for full width changes in green and red.
Details
Details
- Reviewers
epriestley - Maniphest Tasks
- T12089: New red/green highlight colors are incorrect for added or removed new lines
- Commits
- rP63af2275ca05: Re-darken full width diff colors
Review diffs, see full width colors.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- diff-colors (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 15184 Build 19950: Run Core Tests Build 19949: arc lint + arc unit
Event Timeline
Comment Actions
this green has more contrast than the previous "bright" green, just FYI, which is why I made this change.
Comment Actions
If this color scheme isn't good for red-green colorblind users we can introduce a setting, but this was definitely noticeably worse for me too (I just couldn't put my finger on why).