Page MenuHomePhabricator

Remove extra container tag on HandleListViews rendering from ModularTransactions in text mode
ClosedPublic

Authored by epriestley on Jan 9 2017, 4:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 9:21 PM
Unknown Object (File)
Feb 16 2024, 2:27 PM
Unknown Object (File)
Feb 6 2024, 8:41 AM
Unknown Object (File)
Feb 3 2024, 1:50 PM
Unknown Object (File)
Jan 21 2024, 8:29 PM
Unknown Object (File)
Jan 15 2024, 11:58 PM
Unknown Object (File)
Jan 7 2024, 4:56 PM
Unknown Object (File)
Jan 3 2024, 7:24 PM
Subscribers
None

Details

Summary

Fixes T12082. Ref T11114. When modular transaction render a handle list, they use HandleListView, which has a text mode.

However, the HandleListView is a TagView, and currently TagViews always render a tag of some kind. Allow them to return null to decline to render any tag.

Test Plan
  • Added a pile of debugging stuff to ApplicationTransactionEditor to throw during mail generation.
  • Added a reviewer to a revision.
  • Used bin/worker execute --id ... to hit the mail generation repeatedly.
  • Before patch: mail generated with a <span>, even in text mode.
  • After patch: clean mail generation.

Diff Detail

Repository
rP Phabricator
Branch
literal2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phid/view/PHUIHandleListView.php:44XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 15157
Build 19910: Run Core Tests
Build 19909: arc lint + arc unit