Page MenuHomePhabricator

Allow "harbormaster.createartifact" to decode raw HTTP parameter types of artifact properties
ClosedPublic

Authored by epriestley on Nov 17 2016, 1:48 PM.
Tags
None
Referenced Files
F12816890: D16887.id40656.diff
Thu, Mar 28, 3:57 AM
F12815526: D16887.id40653.diff
Thu, Mar 28, 2:59 AM
F12815524: D16887.id.diff
Thu, Mar 28, 2:59 AM
Unknown Object (File)
Fri, Mar 8, 4:02 PM
Unknown Object (File)
Feb 3 2024, 12:56 PM
Unknown Object (File)
Jan 24 2024, 10:20 PM
Unknown Object (File)
Jan 23 2024, 4:41 PM
Unknown Object (File)
Dec 27 2023, 8:20 AM
Subscribers
Restricted Owners Package

Details

Summary

Ref T11887. This isn't a great fix but makes the method behave properly until I get around to a real fix.

In the longer term, I want to convert all of this pluggable Harbormaster/Drydock stuff (blueprints, artifacts, build plans) to use EditEngine + EditField instead of the weird mishmash of older/custom stuff it currently uses. However, this is a more involved project to execute and I'd like to be in that area of the codebase first so it gets adequate testing.

Until that happens, just put a reasonble-ish mechanism in place to let artifacts correct inbound types. This is the only artifact type and only parameter which needs casting.

Test Plan
  • Made a curl call to harbormaster.createartifact to create a URI artifact with ?...&ui.external=1.
  • Before patch: type error on ui.external not being a boolean.
  • After patch: artifact created successfully.

Diff Detail

Repository
rP Phabricator
Branch
atype1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/harbormaster/artifact/HarbormasterURIArtifact.php:31XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 14542
Build 18969: Run Core Tests
Build 18968: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Allow "harbormaster.createartifact" to decode raw HTTP parameter types of artifact properties.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
Owners added a subscriber: Restricted Owners Package.Nov 17 2016, 1:48 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Nov 17 2016, 2:51 PM
This revision was automatically updated to reflect the committed changes.