Default Conpherence Room Search to All Rooms
ClosedPublic
Actions

Authored by chad on Sep 9 2016, 4:00 AM.

Details

Reviewers

Commits

rPfe9f16ad0dd0: Default Conpherence Room Search to All Rooms

Summary

Just changes the default here. Main reasoning is if I'm searching for a room, show me all of them first. "My Rooms" is where I just came from.

Test Plan

Click Search in Conpherence, see All Rooms as default.

Diff Detail

Repository

rP Phabricator

Branch

no-rooms (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13655
Build 17603: Run Core Tests
Build 17602: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39772.Sep 9 2016, 4:00 AM

chad retitled this revision from to Default Conpherence Room Search to All Rooms.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 9 2016, 4:00 AM

epriestley accepted this revision.Sep 9 2016, 10:53 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 9 2016, 10:53 AM

Closed by commit rPfe9f16ad0dd0: Default Conpherence Room Search to All Rooms (authored by chad, committed by chad). · Explain WhySep 9 2016, 2:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

query/

ConpherenceThreadSearchEngine.php

4 lines

Diff 39772

View Options

src/applications/conpherence/query/ConpherenceThreadSearchEngine.php

Default Conpherence Room Search to All RoomsClosedPublicActions