Differential D16524

Printable pages for PHUIDocumentViewPro
ClosedPublic
Actions

Authored by chad on Sep 9 2016, 1:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 18, 2:52 PM

	Unknown Object (File)
	Tue, Apr 16, 11:24 AM

	Unknown Object (File)
	Thu, Apr 11, 10:34 AM

	Unknown Object (File)
	Mon, Apr 8, 6:36 PM

	Unknown Object (File)
	Sun, Mar 31, 7:46 PM

	Unknown Object (File)
	Mar 20 2024, 8:02 PM

	Unknown Object (File)
	Jan 28 2024, 4:31 AM

	Unknown Object (File)
	Jan 22 2024, 10:20 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T10131: Wiki pages are not completely print friendly

Commits

rPd7bc58253073: Printable pages for PHUIDocumentViewPro

Summary

Fixes T10131. Adds new CSS to better present document pages for printing. Added a print link to Phriction.

Test Plan

Tested Phriction, Phame, and Legalpad.

Diff Detail

Repository

Branch

print (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 13650
Build 17596: Run Core Tests
Build 17595: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 39767.Sep 9 2016, 1:48 AM

chad retitled this revision from to Printable pages for PHUIDocumentViewPro.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T10131: Wiki pages are not completely print friendly.

Herald added a subscriber: Korvin. · View Herald TranscriptSep 9 2016, 1:48 AM

epriestley accepted this revision.Sep 9 2016, 2:13 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 9 2016, 2:13 AM

Closed by commit rPd7bc58253073: Printable pages for PHUIDocumentViewPro (authored by chad, committed by chad). · Explain WhySep 9 2016, 2:14 AM

This revision was automatically updated to reflect the committed changes.

pasted_file (2×2 px, 220 KB)

please also add " Unprintable Page" which uses low-contrast text on top of a bright patterned background and has several extra menus and also is 45 feet wide and 2 inches tall

Revision Contents
Changeset List

Path

Size

resources/

celerity/

10 lines

src/

applications/

phriction/

controller/

PhrictionDocumentController.php

23 lines

webroot/

rsrc/

css/

phui/

phui-crumbs-view.css

4 lines

phui-document-pro.css

24 lines

Diff 39767

resources/celerity/map.php

Loading...

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...

webroot/rsrc/css/phui/phui-crumbs-view.css

Loading...

webroot/rsrc/css/phui/phui-document-pro.css

Loading...