Page MenuHomePhabricator
Differential D15946

Add ViewController and SearchEngine for SSH Public Keys
ClosedPublic
Actions

Authored by epriestley on May 19 2016, 4:06 PM.
Tags
None
Referenced Files
F13059712: D15946.diff
Fri, Apr 19, 4:42 PM
F13049010: D15946.diff
Fri, Apr 19, 12:27 AM
Unknown Object (File)
Thu, Apr 11, 8:11 AM
Unknown Object (File)
Mon, Apr 8, 2:06 AM
Unknown Object (File)
Wed, Apr 3, 4:06 PM
Unknown Object (File)
Mon, Apr 1, 11:35 PM
Unknown Object (File)
Mon, Apr 1, 9:22 PM
Unknown Object (File)
Sun, Mar 31, 7:26 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10917: Build Glorious High-Security Notification/Audit Infrastructure
Commits
rP08bea1d363fd: Add ViewController and SearchEngine for SSH Public Keys
Summary

Ref T10917. This primarily prepares these for transactions by giving us a place to:

  • review old deactivated keys; and
  • review changes to keys.

Future changes will add transactions and a timeline so key changes are recorded exhaustively and can be more easily audited.

Test Plan

Screen Shot 2016-05-19 at 9.04.01 AM.png (984×1 px, 161 KB)

Screen Shot 2016-05-19 at 9.04.04 AM.png (984×1 px, 145 KB)

Screen Shot 2016-05-19 at 9.04.09 AM.png (984×1 px, 130 KB)

Screen Shot 2016-05-19 at 9.04.11 AM.png (984×1 px, 131 KB)

Diff Detail

Repository
rP Phabricator
Branch
ssh2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php:52XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 12269
Build 15504: Run Core Tests
Build 15503: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 38399.May 19 2016, 4:06 PM
epriestley retitled this revision from to Add ViewController and SearchEngine for SSH Public Keys.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10917: Build Glorious High-Security Notification/Audit Infrastructure.
chad accepted this revision.May 19 2016, 4:42 PM
chad edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 4:42 PM
Closed by commit rP08bea1d363fd: Add ViewController and SearchEngine for SSH Public Keys (authored by epriestley, committed by epriestley). · Explain WhyMay 19 2016, 4:48 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10917: Build Glorious High-Security Notification/Audit Infrastructure.May 19 2016, 10:20 PM

Revision Contents
Changeset List

Diff 38399

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/almanac/controller/AlmanacDeviceViewController.php

Loading...
View Options

src/applications/auth/application/PhabricatorAuthApplication.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthSSHKeyController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthSSHKeyDeactivateController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthSSHKeyDeleteController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthSSHKeyListController.php

Loading...
View Options

src/applications/auth/controller/PhabricatorAuthSSHKeyViewController.php

Loading...
View Options

src/applications/auth/phid/PhabricatorAuthSSHKeyPHIDType.php

Loading...
View Options

src/applications/auth/query/PhabricatorAuthSSHKeySearchEngine.php

Loading...
View Options

src/applications/auth/storage/PhabricatorAuthSSHKey.php

Loading...
View Options

src/applications/auth/view/PhabricatorAuthSSHKeyTableView.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSSHKeysSettingsPanel.php

Loading...
Phabricator · Built by Phacility