Page MenuHomePhabricator
Differential D14791

Add some documentation about how to set paths with owners.edit
ClosedPublic
Actions

Authored by epriestley on Dec 15 2015, 9:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 12, 4:55 AM
Unknown Object (File)
Thu, Apr 11, 8:43 AM
Unknown Object (File)
Mon, Apr 8, 10:30 AM
Unknown Object (File)
Fri, Apr 5, 12:44 PM
Unknown Object (File)
Wed, Apr 3, 9:30 AM
Unknown Object (File)
Thu, Mar 21, 3:14 PM
Unknown Object (File)
Mar 15 2024, 1:13 PM
Unknown Object (File)
Mar 5 2024, 7:00 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9964: Fill in Conduit support infrastructure for ApplicationEditor changes
Commits
Restricted Diffusion Commit
rP4b3dcd550075: Add some documentation about how to set paths with owners.edit
Summary

Ref T9964.

  • New mechanism for rich documentation on unusual/complicated edits.
  • Add some docs to paths.set since it's not self-evident what you're supposed to pass in.
Test Plan

Screen Shot 2015-12-15 at 1.25.54 PM.png (512×752 px, 74 KB)

Diff Detail

Repository
rP Phabricator
Branch
ee5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9582
Build 11458: Run Core Tests
Build 11457: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35764.Dec 15 2015, 9:26 PM
epriestley retitled this revision from to Add some documentation about how to set paths with owners.edit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9964: Fill in Conduit support infrastructure for ApplicationEditor changes.
chad accepted this revision.Dec 15 2015, 9:26 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2015, 9:26 PM
Closed by commit rP4b3dcd550075: Add some documentation about how to set paths with owners.edit (authored by epriestley, committed by epriestley). · Explain WhyDec 15 2015, 11:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
editor/
32 lines
transactions/
editengine/
6 lines
editfield/
13 lines
edittype/
10 lines

Diff 35764

View Options

src/applications/owners/editor/PhabricatorOwnersPackageEditEngine.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngineAPIMethod.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorEditField.php

Loading...
View Options

src/applications/transactions/edittype/PhabricatorEditType.php

Loading...
Phabricator · Built by Phacility