Differential D14701

Filter PhameHome on active blogs only
ClosedPublic
Actions

Authored by chad on Dec 7 2015, 11:14 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T9928: PhameHome should filter archived blogs

Commits

Restricted Diffusion Commit
rP4973c2357ccd: Filter PhameHome on active blogs only

Summary

Fixes T9928. Not sure if this is best mechanic or add new methods to PhamePostQuery (a join?)

Test Plan

Archive a blog, don't see posts on PhameHome

Diff Detail

Repository

rP Phabricator

Branch

archived-blog

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9372
Build 11143: Run Core Tests
Build 11142: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 35555.Dec 7 2015, 11:14 PM

chad retitled this revision from to Filter PhameHome on active blogs only.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T9928: PhameHome should filter archived blogs.

Herald added a subscriber: Korvin. · View Herald TranscriptDec 7 2015, 11:14 PM

epriestley accepted this revision.Dec 7 2015, 11:58 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/phame/controller/PhameHomeController.php
15–18	(You can omit this, as it's the default.)

This revision is now accepted and ready to land.Dec 7 2015, 11:58 PM

epriestley awarded a token.Dec 7 2015, 11:58 PM

Closed by commit rP4973c2357ccd: Filter PhameHome on active blogs only (authored by chad, committed by chad). · Explain WhyDec 8 2015, 3:24 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

phame/

controller/

PhameHomeController.php

26 lines

Diff 35555

View Options

src/applications/phame/controller/PhameHomeController.php

Filter PhameHome on active blogs onlyClosedPublicActions