Page MenuHomePhabricator
Differential D14602

Add a linter rule for variable reference spacing
ClosedPublic
Actions

Authored by joshuaspence on Nov 30 2015, 11:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 27, 3:20 AM
Unknown Object (File)
Tue, Nov 26, 1:55 AM
Unknown Object (File)
Wed, Nov 20, 3:14 AM
Unknown Object (File)
Sat, Nov 16, 1:46 AM
Unknown Object (File)
Tue, Nov 12, 1:53 PM
Unknown Object (File)
Mon, Nov 11, 6:16 AM
Unknown Object (File)
Mon, Nov 11, 6:16 AM
Unknown Object (File)
Fri, Nov 8, 10:56 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC87306cfe1453: Add a linter rule for variable reference spacing
Summary

Adds a linter rule for spacing after the & token, similar to ArcanistUnaryPrefixExpressionSpacingXHPASTLinterRule.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Test Failures
Build Status
Buildable 9159
Build 10817: Run Core Tests
Build 10816: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
529 msArcanistPuppetLintLinterTestCase::Unknown Unit Message ("")
64 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
24 msArcanistAbstractMethodBodyXHPASTLinterRuleTestCase::Unknown Unit Message ("")
22 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
10 msArcanistAbstractPrivateMethodXHPASTLinterRuleTestCase::Unknown Unit Message ("")
View Full Test Results (1 Failed · 290 Passed · 46 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 35322.Nov 30 2015, 11:15 AM
joshuaspence retitled this revision from to Add a linter rule for variable reference spacing.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptNov 30 2015, 11:15 AM
Herald added a subscriber: Korvin. · View Herald Transcript
epriestley accepted this revision.Nov 30 2015, 1:08 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 30 2015, 1:08 PM
joshuaspence updated this revision to Diff 35349.Nov 30 2015, 8:21 PM
joshuaspence edited edge metadata.

Minor tidying

Closed by commit rARC87306cfe1453: Add a linter rule for variable reference spacing (authored by joshuaspence, committed by joshuaspence). · Explain WhyNov 30 2015, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 35349

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/lint/linter/xhpast/rules/ArcanistVariableReferenceSpacingXHPASTLinterRule.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/ArcanistVariableReferenceSpacingXHPASTLinterRuleTestCase.php

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/variable-reference-spacing/function-call.lint-test

Loading...
View Options

src/lint/linter/xhpast/rules/__tests__/variable-reference-spacing/variable.lint-test

Loading...
Phabricator · Built by Phacility