Fix "Accepted" status constant in landing
ClosedPublic
Actions

Authored by epriestley on Oct 27 2015, 7:04 PM.

Details

Reviewers

chad

Commits

Restricted Diffusion Commit
rP198bf1198daf: Fix "Accepted" status constant in landing

Summary

I didn't test the positive version of this -- the constant has value 2 but when we read it from the database it's "2" or whatever. Just do this for now and maybe someday we'll use strings.

Test Plan

will do production things

Diff Detail

Repository

rP Phabricator

Branch

accepted

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 8452
Build 9723: Run Core Tests
Build 9722: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 34644.Oct 27 2015, 7:04 PM

epriestley retitled this revision from to Fix "Accepted" status constant in landing.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

chad accepted this revision.Oct 27 2015, 7:06 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 27 2015, 7:06 PM

Closed by commit rP198bf1198daf: Fix "Accepted" status constant in landing (authored by epriestley, committed by epriestley). · Explain WhyOct 27 2015, 7:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

operation/

DrydockLandRepositoryOperation.php

2 lines

Diff 34644

View Options

src/applications/drydock/operation/DrydockLandRepositoryOperation.php

Fix "Accepted" status constant in landingClosedPublicActions