Page MenuHomePhabricator

Set a property so that unit tests run on PHP7
ClosedPublic

Authored by Mnkras on Oct 26 2015, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 25, 9:50 AM
Unknown Object (File)
Mon, Mar 25, 9:50 AM
Unknown Object (File)
Mon, Mar 25, 9:43 AM
Unknown Object (File)
Mon, Mar 18, 4:59 PM
Unknown Object (File)
Fri, Mar 15, 5:00 PM
Unknown Object (File)
Mon, Mar 4, 6:08 PM
Unknown Object (File)
Mon, Mar 4, 6:08 PM
Unknown Object (File)
Mon, Mar 4, 3:53 PM
Subscribers

Details

Summary

Without this change PHP throws because idx() is passed null as the property is not intialzied

Test Plan

arc unit --everything

Diff Detail

Repository
rP Phabricator
Branch
php7-unit
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 8427
Build 9686: arc lint + arc unit

Event Timeline

Mnkras retitled this revision from to Set a property so that unit tests run on PHP7.
Mnkras updated this object.
Mnkras edited the test plan for this revision. (Show Details)
epriestley added a reviewer: epriestley.

If you hold this for a bit you can try "Land Revision".

This revision is now accepted and ready to land.Oct 26 2015, 7:38 PM
This revision was automatically updated to reflect the committed changes.