Page MenuHomePhabricator
Differential D14029

Fix an issue with "packages(...)" in typeaheads
ClosedPublic
Actions

Authored by epriestley on Sep 1 2015, 11:17 AM.
Tags
None
Referenced Files
F13061951: D14029.diff
Fri, Apr 19, 8:31 PM
Unknown Object (File)
Thu, Apr 18, 6:33 AM
Unknown Object (File)
Tue, Apr 16, 4:19 AM
Unknown Object (File)
Mon, Apr 8, 9:10 PM
Unknown Object (File)
Sun, Apr 7, 8:00 PM
Unknown Object (File)
Tue, Apr 2, 5:11 PM
Unknown Object (File)
Sun, Mar 24, 7:11 AM
Unknown Object (File)
Mar 6 2024, 5:08 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9302: Audits for owned packages no longer showing up
Commits
Restricted Diffusion Commit
rP13516cf35f03: Fix an issue with "packages(...)" in typeaheads
Summary

Fixes T9302. This datasource wasn't resolving package PHIDs correctly for the actual query.

Also fixes an issue with the "Affected packages that need audit" Herald rule.

Test Plan

Ran a "Needs Audit" query with only packages, and only packages(user).

Diff Detail

Repository
rP Phabricator
Branch
auditfix1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7871
Build 8773: [Placeholder Plan] Wait for 30 Seconds
Build 8772: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 33917.Sep 1 2015, 11:17 AM
epriestley retitled this revision from to Fix an issue with "packages(...)" in typeaheads.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9302: Audits for owned packages no longer showing up.
chad accepted this revision.Sep 1 2015, 3:17 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Sep 1 2015, 3:17 PM
Closed by commit rP13516cf35f03: Fix an issue with "packages(...)" in typeaheads (authored by epriestley, committed by epriestley). · Explain WhySep 1 2015, 10:35 PM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
20 lines
src/
applications/
diffusion/
herald/
4 lines
owners/
typeahead/
11 lines

Diff 33917

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/herald/HeraldCommitAdapter.php

Loading...
View Options

src/applications/owners/typeahead/PhabricatorOwnersPackageOwnerDatasource.php

Loading...
Phabricator · Built by Phacility