Page MenuHomePhabricator
Differential D13986

Remove unused last_token macro
ClosedPublic
Actions

Authored by joshuaspence on Aug 24 2015, 11:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 1:08 AM
Unknown Object (File)
Sun, Apr 7, 1:34 PM
Unknown Object (File)
Fri, Apr 5, 11:22 AM
Unknown Object (File)
Wed, Apr 3, 11:29 AM
Unknown Object (File)
Wed, Apr 3, 11:29 AM
Unknown Object (File)
Wed, Apr 3, 11:29 AM
Unknown Object (File)
Wed, Apr 3, 11:19 AM
Unknown Object (File)
Tue, Mar 26, 3:47 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUc5e78941746d: Remove unused last_token macro
Summary

This macro is unused after D1319.

Test Plan

grep

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7769
Build 8570: [Placeholder Plan] Wait for 30 Seconds
Build 8569: arc lint + arc unit

Event Timeline

joshuaspence updated this revision to Diff 33760.Aug 24 2015, 11:15 AM
joshuaspence retitled this revision from to Remove unused last_token macro.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 24 2015, 11:15 AM
Herald added a subscriber: Korvin. · View Herald Transcript
joshuaspence updated this revision to Diff 33761.Aug 24 2015, 11:18 AM
joshuaspence edited edge metadata.

Remove another unused macro

epriestley accepted this revision.Aug 24 2015, 4:31 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 24 2015, 4:31 PM
Closed by commit rPHUc5e78941746d: Remove unused last_token macro (authored by joshuaspence, committed by joshuaspence). · Explain WhyAug 25 2015, 3:11 AM
This revision was automatically updated to reflect the committed changes.
• cyn0228.ch added a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:42 PM
chad removed a task: T5375: Tokenizers fail in Firefox on Android.Sep 7 2015, 10:45 PM

Revision Contents
Changeset List

PathSize
support/
xhpast/
4 lines
2 lines
306 lines

Diff 33761

View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
Phabricator · Built by Phacility