Differential D13800

Add user icons / colors for subscriber transactions
ClosedPublic
Actions

Authored by chad on Aug 5 2015, 7:28 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP2383e741aa74: Add user icons / colors for subscriber transactions

Summary

Adds additional icon states for subscriber transactions. Also updated "eraser" to "trash" (man that icon is bad).

Test Plan

add a subscriber, remove a subscriber.

Diff Detail

Repository

rP Phabricator

Branch

transaction-icons

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 7497
Build 8034: [Placeholder Plan] Wait for 30 Seconds
Build 8033: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 33328.Aug 5 2015, 7:28 PM

chad retitled this revision from to Add user icons / colors for subscriber transactions.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptAug 5 2015, 7:28 PM

epriestley accepted this revision.Aug 5 2015, 7:39 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 5 2015, 7:39 PM

Closed by commit rP2383e741aa74: Add user icons / colors for subscriber transactions (authored by chad, committed by chad). · Explain WhyAug 5 2015, 7:40 PM

This revision was automatically updated to reflect the committed changes.

These are really jumping out at me now, and are some of the least interesting transactions.

yeah... this is mostly a redesign timeline issue (use non-bright colors). I can retract the colors if its not working.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorApplicationTransaction.php

31 lines

Diff 33328

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Add user icons / colors for subscriber transactionsClosedPublicActions