Page MenuHomePhabricator

Modularize "add projects" and "remove projects" Herald actions
ClosedPublic

Authored by epriestley on Jul 24 2015, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 21, 6:35 AM
Unknown Object (File)
Mon, Mar 18, 9:05 PM
Unknown Object (File)
Sat, Mar 16, 6:41 AM
Unknown Object (File)
Fri, Mar 1, 1:19 PM
Unknown Object (File)
Fri, Mar 1, 12:25 PM
Unknown Object (File)
Thu, Feb 29, 11:28 PM
Unknown Object (File)
Feb 21 2024, 5:09 AM
Unknown Object (File)
Feb 11 2024, 11:30 PM
Tokens
"Orange Medal" token, awarded by joshuaspence.

Details

Summary

Ref T8726. Convert these to be modular.

Test Plan
  • Created rules using these actions.
  • Upgraded them.
  • Verified they still work.

Screen Shot 2015-07-24 at 12.24.07 PM.png (200×495 px, 33 KB)

Diff Detail

Repository
rP Phabricator
Branch
heraldx6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 7383
Build 7806: [Placeholder Plan] Wait for 30 Seconds
Build 7805: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Modularize "add projects" and "remove projects" Herald actions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
btrahan added inline comments.
src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php
1244

duplicate s

This revision is now accepted and ready to land.Jul 25 2015, 12:01 AM
epriestley edited edge metadata.
  • Fix duplicate "ss".
joshuaspence rescinded a token.
joshuaspence awarded a token.
joshuaspence added a subscriber: joshuaspence.
This revision was automatically updated to reflect the committed changes.