Differential D12250

Fix a tokenizer issue in a rare edge case
ClosedPublic
Actions

Authored by epriestley on Apr 1 2015, 7:07 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7689: Load handles just-in-time

Commits

Restricted Diffusion Commit
rP983c6f9d4bcb: Fix a tokenizer issue in a rare edge case

Summary

Ref T7689. We may not propgate the viewer down to the controls in some rendering pathways. An example is "Create Task..." on workboard columns.

Instead, move the propagation a little deeper.

Test Plan

"Create Task..." on a workboard column.

Diff Detail

Repository

rP Phabricator

Branch

tok1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5087
Build 5105: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29424.Apr 1 2015, 7:07 PM

epriestley retitled this revision from to Fix a tokenizer issue in a rare edge case.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7689: Load handles just-in-time.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 1 2015, 7:07 PM

btrahan accepted this revision.Apr 1 2015, 7:24 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 1 2015, 7:24 PM

Closed by commit rP983c6f9d4bcb: Fix a tokenizer issue in a rare edge case (authored by epriestley, committed by epriestley). · Explain WhyApr 1 2015, 7:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

form/

AphrontFormView.php

8 lines

Diff 29424

View Options

src/view/form/AphrontFormView.php

Fix a tokenizer issue in a rare edge caseClosedPublicActions