Paths

Table of Contentst

Differential D12026

Prepare TransactionCommentQuery for extension
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 7:18 PM.

Tags

None

Referenced Files

	F13084420: D12026.diff
	Wed, Apr 24, 10:59 PM

	Unknown Object (File)
	Tue, Apr 23, 10:49 AM

	Unknown Object (File)
	Mon, Apr 22, 8:28 PM

	Unknown Object (File)
	Wed, Apr 17, 2:31 PM

	Unknown Object (File)
	Tue, Apr 16, 8:09 PM

	Unknown Object (File)
	Tue, Apr 16, 8:09 PM

	Unknown Object (File)
	Tue, Apr 16, 7:46 PM

	Unknown Object (File)
	Tue, Apr 16, 6:23 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
T1460: Add "Done" link to an inline comment

Commits

Restricted Diffusion Commit
rP4d86d51125fe: Prepare TransactionCommentQuery for extension

Summary

Ref T2009. Ref T1460. The way Diffusion and Differential load inlines is horrible garbage right now:

Differential does an ad-hoc query to get the PHIDs, then does a real load to policy check.
Diffusion completely fakes things. In practice this is not a policy violation, but it's dangerous.

Make TransactionCommentQuery extensible so we can subclass it and get the query building correctly in the right Query layer.

Specifically, the Diffusion and Differential subclasses of this Query will add appropriate withX() methods to let us express the query in SQL.

Test Plan

Loaded, previewed, edited, and submitted inlines in Differential and Diffusion

Diff Detail

Repository

Branch

uni34

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/differential/query/DifferentialTransactionQuery.php:14	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 4819
Build 4835: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28949.Mar 9 2015, 7:18 PM

epriestley retitled this revision from to Prepare TransactionCommentQuery for extension.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T1460: Add "Done" link to an inline comment, T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 7:18 PM

epriestley added inline comments.Mar 9 2015, 7:21 PM

src/applications/transactions/query/PhabricatorApplicationTransactionTemplatedCommentQuery.php
3–4	I split out this concrete subclass because I didn't want nonsense like this to work: $differential_query = new DifferentialCommentQuery(); $differential_query->setTemplate(new ManiphestTransactionComment()); $differential_query->execute(); // What kind of object does this load?

btrahan accepted this revision.Mar 9 2015, 8:42 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 9 2015, 8:42 PM

Closed by commit rP4d86d51125fe: Prepare TransactionCommentQuery for extension (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 9:11 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__phutil_library_map__.php

2 lines

applications/

differential/

query/

DifferentialTransactionQuery.php

8 lines

transactions/

controller/

PhabricatorApplicationTransactionCommentHistoryController.php

2 lines

query/

PhabricatorApplicationTransactionCommentQuery.php

59 lines

PhabricatorApplicationTransactionQuery.php

11 lines

PhabricatorApplicationTransactionTemplatedCommentQuery.php

18 lines

infrastructure/

diff/

PhabricatorInlineCommentController.php

11 lines

Diff 28949

src/__phutil_library_map__.php

Loading...

src/applications/differential/query/DifferentialTransactionQuery.php

Loading...

src/applications/transactions/controller/PhabricatorApplicationTransactionCommentHistoryController.php

Loading...

src/applications/transactions/query/PhabricatorApplicationTransactionCommentQuery.php

Loading...

src/applications/transactions/query/PhabricatorApplicationTransactionQuery.php

Loading...

src/applications/transactions/query/PhabricatorApplicationTransactionTemplatedCommentQuery.php

Loading...

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...