Page MenuHomePhabricator

Add support for xUnit.NET 2 and improve build / test performance
AbandonedPublic

Authored by hach-que on Feb 5 2015, 6:06 AM.
Tags
None
Referenced Files
F13090482: D11689.diff
Thu, Apr 25, 2:24 AM
Unknown Object (File)
Fri, Apr 19, 9:33 PM
Unknown Object (File)
Wed, Apr 17, 7:20 AM
Unknown Object (File)
Sat, Apr 13, 11:38 AM
Unknown Object (File)
Sat, Apr 13, 11:37 AM
Unknown Object (File)
Sat, Apr 13, 11:01 AM
Unknown Object (File)
Sat, Apr 13, 9:42 AM
Unknown Object (File)
Fri, Mar 29, 10:30 PM
Subscribers

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Summary

This adds support for xUnit.NET 2 and improves the performance of building and testing. Building is improved by getting MSBuild to build everything in parallel, rather than invoking MSBuild for each project, and testing is improved because xUnit.NET 2 supports testing multiple assemblies in parallel. This means that the Arcanist unit test runner only needs to exec two processes for the whole operation, instead of two processes per assembly.

This also depends on D11688 landing in libphutil first.

Test Plan

Ran it against a code base using xUnit.NET 2.

Diff Detail

Repository
rARC Arcanist
Branch
xunit2
Lint
Lint Skipped
Unit
Test Failures
Build Status
Buildable 4346
Build 4359: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed

TimeTest
198 msArcanistLibraryTestCase::testLibraryMap
29 msPhpunitTestEngineTestCase::testSearchLocations
41 msArcanistLibraryTestCase::testEverythingImplemented
50 msArcanistLibraryTestCase::testMethodVisibility
0 msPhutilUnitTestEngineTestCase::testFailSkip
View Full Test Results (2 Failed · 6 Passed)

Event Timeline

hach-que retitled this revision from to Add support for xUnit.NET 2 and improve build / test performance.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que edited edge metadata.
  • Remove "Discovered" test notifications
epriestley edited edge metadata.

New test engines should wait for T5568.

This revision now requires changes to proceed.Aug 8 2015, 6:40 PM