Differential D11284

Pass `--host` to `aphlict_server.js`
ClosedPublic
Actions

Authored by joshuaspence on Jan 8 2015, 9:58 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T6559: Change notification system implementation not to require Flash

Commits

Restricted Diffusion Commit
rP5c25f380389a: Pass `--host` to `aphlict_server.js`

Summary

This was omitted in D11143.

Test Plan

I don't always test, but when I do... I do it in production.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3696
Build 3706: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 27113.Jan 8 2015, 9:58 PM

joshuaspence retitled this revision from to Pass `--host` to `aphlict_server.js`.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 8 2015, 9:58 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

joshuaspence mentioned this in D11285: Stop advising users to use `npm -g` to install websockets.Jan 8 2015, 10:00 PM

epriestley accepted this revision.Jan 8 2015, 10:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Jan 8 2015, 10:01 PM

Closed by commit rP5c25f380389a: Pass `--host` to `aphlict_server.js` (authored by joshuaspence, committed by joshuaspence). · Explain WhyJan 8 2015, 10:01 PM

This revision was automatically updated to reflect the committed changes.

joshuaspence added a task: T6559: Change notification system implementation not to require Flash.Jan 9 2015, 12:27 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

aphlict/

management/

PhabricatorAphlictManagementWorkflow.php

1 line

Diff 27113

View Options

src/applications/aphlict/management/PhabricatorAphlictManagementWorkflow.php

Pass `--host` to `aphlict_server.js`ClosedPublicActions