Page MenuHomePhabricator
Differential D10435

Patch the `JSONLint` external to be compatible with PHP 5.2
ClosedPublic
Actions

Authored by joshuaspence on Sep 6 2014, 7:26 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 11, 8:12 AM
Unknown Object (File)
Tue, Apr 9, 4:02 PM
Unknown Object (File)
Mon, Apr 8, 10:52 AM
Unknown Object (File)
Fri, Mar 22, 1:44 AM
Unknown Object (File)
Fri, Mar 22, 1:44 AM
Unknown Object (File)
Mar 18 2024, 8:22 AM
Unknown Object (File)
Feb 9 2024, 6:02 PM
Unknown Object (File)
Feb 9 2024, 6:02 PM
View All Files
Subscribers
epriestley
Korvin
talshiri

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHUbfc4a6aa18ee: Patch the `JSONLint` external to be compatible with PHP 5.2
Summary

The JSONLint external utilizes the shorthand ternary (?:) syntax, which is only available from PHP 5.3. Expand the shorthand ternary form into ordinary ternary form to ensure compatibility with PHP 5.2. Depends on D10433.

Test Plan

Not sure how...

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 2453
Build 2457: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 25096.Sep 6 2014, 7:26 AM
joshuaspence retitled this revision from to Patch the `JSONLint` external to be compatible with PHP 5.2.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a parent revision: D10433: Update the `JSONLint` API.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 6 2014, 7:26 AM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2453: Diff 25096.Sep 6 2014, 7:27 AM
epriestley accepted this revision.Sep 8 2014, 1:50 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 8 2014, 1:50 PM
joshuaspence closed this revision.Sep 8 2014, 11:06 PM
joshuaspence updated this revision to Diff 25129.

Closed by commit rPHUbfc4a6aa18ee (authored by @joshuaspence).

talshiri added a subscriber: talshiri.Sep 9 2014, 12:05 AM

This causes Phabricator to blow up on our install
Call to undefined method JsonLintLexer::len()
callstack:

...
phutil_json_decode() /Users/tal/dev/phabricator/phabricator/src/applications/differential/customfield/DifferentialAuditorsField.php:24
PhutilJSONParser->parse() /Users/tal/dev/phabricator/libphutil/src/utils/utils.php:1053
JsonLintJsonParser->parse() /Users/tal/dev/phabricator/libphutil/src/parser/PhutilJSONParser.php:27
JsonLintJsonParser->lex() /Users/tal/dev/phabricator/libphutil/externals/jsonlint/src/Seld/JsonLint/JsonParser.php:178

Our php:

PHP 5.4.24 (cli) (built: Jan 19 2014 21:32:15) 
Copyright (c) 1997-2013 The PHP Group
Zend Engine v2.4.0, Copyright (c) 1998-2013 Zend Technologies
epriestley added a comment.EditedSep 9 2014, 1:24 AM

rPHUe1c7a6ee32d272762d70cf63ef0b9c974f84a300

Revision Contents
Changeset List

PathSize
externals/
jsonlint/
src/
Seld/
JsonLint/
10 lines

Diff 25096

View Options

externals/jsonlint/src/Seld/JsonLint/JsonParser.php

Loading...
Phabricator · Built by Phacility