Differential D9744

Fixes T4990
ClosedPublic
Actions

Authored by derki on Jun 26 2014, 4:31 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T4990: Hunt down and resolve TERM=dumb issue for SSH hosting

Commits

Restricted Diffusion Commit
rPd541664956c7: Fixes T4990

Summary

Fix for T4990, using export TERM directly in pre receive hook, tested for git

Test Plan

pushing into repository over ssh will now not cause remote warning
No entry for terminal type "unknown";
using dumb terminal settings.

Tested with git

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 1415
Build 1415: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

derki updated this revision to Diff 23400.Jun 26 2014, 4:31 PM

derki retitled this revision from to Fixes T4990.

derki updated this object.

derki edited the test plan for this revision. (Show Details)

derki added a reviewer: epriestley.

derki added projects: Diffusion, Repositories.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJun 26 2014, 4:31 PM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B1415: Diff 23400.Jun 26 2014, 4:32 PM

chad added a task: T4990: Hunt down and resolve TERM=dumb issue for SSH hosting.Jun 26 2014, 4:38 PM

Thanks!

This revision is now accepted and ready to land.Jun 26 2014, 4:40 PM

Closed by commit rPd541664956c7 (authored by @epriestley).

alexmv mentioned this in D17100: Set `TERM` to prevent `No entry for terminal type "unknown"` messages during fetch.Dec 21 2016, 10:58 PM

alexmv mentioned this in rP972604e0e59c: Set `TERM` to prevent `No entry for terminal type "unknown"` messages during….Dec 21 2016, 11:17 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryPullEngine.php

2 lines

Diff 23400

View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

Fixes T4990ClosedPublicActions