Paths

Table of Contentst

Differential D8688

Simplify oncopy behavior
ClosedPublic
Actions

Authored by sophiebits on Apr 3 2014, 8:24 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 10:31 AM

	Unknown Object (File)
	Wed, Apr 10, 8:27 AM

	Unknown Object (File)
	Wed, Apr 10, 7:37 AM

	Unknown Object (File)
	Tue, Apr 2, 10:11 AM

	Unknown Object (File)
	Sat, Mar 30, 11:29 AM

	Unknown Object (File)
	Fri, Mar 29, 10:45 AM

	Unknown Object (File)
	Feb 4 2024, 7:19 PM

	Unknown Object (File)
	Feb 4 2024, 7:18 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rP26c836e1e14e: Simplify oncopy behavior

Summary

Firefox has supported clipboardData since version 22 (Jul 2013), and even IE8 supports it if you look at window.clipboardData instead of e.clipboardData. As a result, we can simplify this code significantly.

I also used (or at least, attempted to) Javelin so that we can get the event object and preventDefault more easily. Plus, this way we don't assign to document.body.oncopy.

Test Plan

Copied a selection including a line number in Chrome, Firefox, and IE8. The line number didn't get copied.

Diff Detail

Repository

Branch

simplify-oncopy

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

sophiebits updated this revision to Diff 20600.Apr 3 2014, 8:24 AM

sophiebits retitled this revision from to Simplify oncopy behavior.

sophiebits updated this object.

sophiebits edited the test plan for this revision. (Show Details)

sophiebits added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers.Apr 3 2014, 8:24 AM

Herald added subscribers: Korvin, epriestley.

July 2013 is kind of recent (see D835) but if anyone complains we can revert this and then apply it in a year or two.

This revision is now accepted and ready to land.Apr 3 2014, 4:20 PM

Closed by commit rP26c836e1e14e (authored by @spicyj, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

resources/

celerity/

16 lines

webroot/

rsrc/

js/

core/

behavior-oncopy.js

97 lines

Diff 20600

resources/celerity/map.php

Loading...

webroot/rsrc/js/core/behavior-oncopy.js

Loading...