Use new Google+ API for Google auth instead of "userinfo"
ClosedPublic
Actions

Authored by epriestley on Mar 25 2014, 6:29 PM.

Details

Reviewers

btrahan

Commits

rPHU1ea12a01671d: Use new Google+ API for Google auth instead of "userinfo"

Summary

Google is moving away from the APIs we're using, as described in this timetable:

https://developers.google.com/+/api/auth-migration#timetable

Although the timetable says the API is good until Sept 1, 2014, we're seeing the API fail on secure.phabricator.com and have received user reports of failures as well.

I can't figure out any configuration changes that users can make to keep the current APIs working, so just upgrade to the new ones.

Test Plan

Registered and logged in with Google.

Diff Detail

Repository

rPHU libphutil

Branch

plus1

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/auth/PhutilAuthAdapterOAuthGoogle.php:53	XHP16	TODO Comment

Unit

No Test Coverage

Event Timeline

epriestley updated this revision to Diff 20405.Mar 25 2014, 6:29 PM

epriestley retitled this revision from to Use new Google+ API for Google auth instead of "userinfo".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley.Mar 25 2014, 6:29 PM

Raise a more specific and hopefully more useful exception.

btrahan accepted this revision.Mar 25 2014, 7:31 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 25 2014, 7:31 PM

Closed by commit rPHU1ea12a01671d (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

auth/

PhutilAuthAdapterOAuthGoogle.php

35 lines

Diff 20405

View Options

src/auth/PhutilAuthAdapterOAuthGoogle.php

Use new Google+ API for Google auth instead of "userinfo"ClosedPublicActions