Differential D21864 Diff 52157 src/applications/repository/storage/PhabricatorRepositoryCommitData.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/repository/storage/PhabricatorRepositoryCommitData.php
Show First 20 Lines • Show All 91 Lines • ▼ Show 20 Lines | public function newPublisherHoldReasons() { | ||||
return array_values($holds); | return array_values($holds); | ||||
} | } | ||||
public function getAuthorString() { | public function getAuthorString() { | ||||
$ref = $this->getCommitRef(); | $ref = $this->getCommitRef(); | ||||
$author = $ref->getAuthor(); | $author = $ref->getAuthor(); | ||||
if (strlen($author)) { | if ($author !== null && strlen($author)) { | ||||
return $author; | return $author; | ||||
} | } | ||||
$author = phutil_string_cast($this->authorName); | $author = phutil_string_cast($this->authorName); | ||||
if (strlen($author)) { | if (strlen($author)) { | ||||
return $author; | return $author; | ||||
} | } | ||||
Show All 17 Lines | public function getAuthorEpoch() { | ||||
return null; | return null; | ||||
} | } | ||||
public function getCommitterString() { | public function getCommitterString() { | ||||
$ref = $this->getCommitRef(); | $ref = $this->getCommitRef(); | ||||
$committer = $ref->getCommitter(); | $committer = $ref->getCommitter(); | ||||
if (strlen($committer)) { | if ($committer !== null && strlen($committer)) { | ||||
return $committer; | return $committer; | ||||
} | } | ||||
return $this->getCommitDetailString('committer'); | return $this->getCommitDetailString('committer'); | ||||
} | } | ||||
public function getCommitterDisplayName() { | public function getCommitterDisplayName() { | ||||
return $this->getCommitRef()->getCommitterName(); | return $this->getCommitRef()->getCommitterName(); | ||||
▲ Show 20 Lines • Show All 49 Lines • Show Last 20 Lines |