Differential D21864 Diff 52157 src/applications/diffusion/conduit/DiffusionBranchQueryConduitAPIMethod.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/diffusion/conduit/DiffusionBranchQueryConduitAPIMethod.php
Show All 24 Lines | protected function defineCustomParamTypes() { | ||||
); | ); | ||||
} | } | ||||
protected function getGitResult(ConduitAPIRequest $request) { | protected function getGitResult(ConduitAPIRequest $request) { | ||||
$drequest = $this->getDiffusionRequest(); | $drequest = $this->getDiffusionRequest(); | ||||
$repository = $drequest->getRepository(); | $repository = $drequest->getRepository(); | ||||
$contains = $request->getValue('contains'); | $contains = $request->getValue('contains'); | ||||
if (strlen($contains)) { | if ($contains !== null && strlen($contains)) { | ||||
// See PHI958 (and, earlier, PHI720). If "patterns" are provided, pass | // See PHI958 (and, earlier, PHI720). If "patterns" are provided, pass | ||||
// them to "git branch ..." to let callers test for reachability from | // them to "git branch ..." to let callers test for reachability from | ||||
// particular branch heads. | // particular branch heads. | ||||
$patterns_argv = $request->getValue('patterns', array()); | $patterns_argv = $request->getValue('patterns', array()); | ||||
PhutilTypeSpec::checkMap( | PhutilTypeSpec::checkMap( | ||||
array( | array( | ||||
'patterns' => $patterns_argv, | 'patterns' => $patterns_argv, | ||||
Show All 33 Lines | final class DiffusionBranchQueryConduitAPIMethod | ||||
protected function getMercurialResult(ConduitAPIRequest $request) { | protected function getMercurialResult(ConduitAPIRequest $request) { | ||||
$drequest = $this->getDiffusionRequest(); | $drequest = $this->getDiffusionRequest(); | ||||
$repository = $drequest->getRepository(); | $repository = $drequest->getRepository(); | ||||
$query = id(new DiffusionLowLevelMercurialBranchesQuery()) | $query = id(new DiffusionLowLevelMercurialBranchesQuery()) | ||||
->setRepository($repository); | ->setRepository($repository); | ||||
$contains = $request->getValue('contains'); | $contains = $request->getValue('contains'); | ||||
if (strlen($contains)) { | if ($contains !== null && strlen($contains)) { | ||||
$query->withContainsCommit($contains); | $query->withContainsCommit($contains); | ||||
} | } | ||||
$refs = $query->execute(); | $refs = $query->execute(); | ||||
return $this->processBranchRefs($request, $refs); | return $this->processBranchRefs($request, $refs); | ||||
} | } | ||||
▲ Show 20 Lines • Show All 45 Lines • Show Last 20 Lines |