Differential D21864 Diff 52157 src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php
Show First 20 Lines • Show All 245 Lines • ▼ Show 20 Lines | $show_diff = phutil_tag( | ||||
'button', | 'button', | ||||
array(), | array(), | ||||
pht('Show Diff')), | pht('Show Diff')), | ||||
)); | )); | ||||
$content = phabricator_form( | $content = phabricator_form( | ||||
$this->getUser(), | $this->getUser(), | ||||
array( | array( | ||||
'method' => 'GET', | |||||
cspeckmim: This prevents null value further down through `phabricator_form`. I looked through a number of… | |||||
'action' => '/D'.$revision_id.'#toc', | 'action' => '/D'.$revision_id.'#toc', | ||||
), | ), | ||||
array( | array( | ||||
$table, | $table, | ||||
$show_diff, | $show_diff, | ||||
)); | )); | ||||
return $content; | return $content; | ||||
▲ Show 20 Lines • Show All 80 Lines • Show Last 20 Lines |
This prevents null value further down through phabricator_form. I looked through a number of call sites and I think this is the only place that wasn't passing in method. I didn't go through the call hierarchy though so there were a few sites that were passing in attribute arrays computed from other things.