Differential D21678 Diff 51616 src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
Show First 20 Lines • Show All 717 Lines • ▼ Show 20 Lines | try { | ||||
$err = $ex->getError(); | $err = $ex->getError(); | ||||
$stdout = $ex->getStdout(); | $stdout = $ex->getStdout(); | ||||
// NOTE: Between versions 2.1 and 2.1.1, Mercurial changed the behavior | // NOTE: Between versions 2.1 and 2.1.1, Mercurial changed the behavior | ||||
// of "hg pull" to return 1 in case of a successful pull with no changes. | // of "hg pull" to return 1 in case of a successful pull with no changes. | ||||
// This behavior has been reverted, but users who updated between Feb 1, | // This behavior has been reverted, but users who updated between Feb 1, | ||||
// 2012 and Mar 1, 2012 will have the erroring version. Do a dumb test | // 2012 and Mar 1, 2012 will have the erroring version. Do a dumb test | ||||
// against stdout to check for this possibility. | // against stdout to check for this possibility. | ||||
// See: https://github.com/phacility/phabricator/issues/101/ | |||||
// NOTE: Mercurial has translated versions, which translate this error | // NOTE: Mercurial has translated versions, which translate this error | ||||
// string. In a translated version, the string will be something else, | // string. In a translated version, the string will be something else, | ||||
// like "aucun changement trouve". There didn't seem to be an easy way | // like "aucun changement trouve". There didn't seem to be an easy way | ||||
// to handle this (there are hard ways but this is not a common problem | // to handle this (there are hard ways but this is not a common problem | ||||
// and only creates log spam, not application failures). Assume English. | // and only creates log spam, not application failures). Assume English. | ||||
// TODO: Remove this once we're far enough in the future that deployment | // TODO: Remove this once we're far enough in the future that deployment | ||||
▲ Show 20 Lines • Show All 111 Lines • Show Last 20 Lines |