Changeset View
Changeset View
Standalone View
Standalone View
src/applications/repository/storage/PhabricatorRepositoryCommit.php
Show First 20 Lines • Show All 708 Lines • ▼ Show 20 Lines | public function getCircleCIGitHubRepositoryURI() { | ||||
} | } | ||||
$remote_uri = $repository->getRemoteURI(); | $remote_uri = $repository->getRemoteURI(); | ||||
$path = HarbormasterCircleCIBuildStepImplementation::getGitHubPath( | $path = HarbormasterCircleCIBuildStepImplementation::getGitHubPath( | ||||
$remote_uri); | $remote_uri); | ||||
if (!$path) { | if (!$path) { | ||||
throw new Exception( | throw new Exception( | ||||
pht( | pht( | ||||
'This commit ("%s") is associated with a repository ("%s") that '. | 'This commit ("%s") is associated with a repository ("%s") '. | ||||
'with a remote URI ("%s") that does not appear to be hosted on '. | 'with a remote URI ("%s") that does not appear to be hosted on '. | ||||
epriestley: Maybe "...which has a remote URI..." would be slightly clearer than "...with an X with a Y...". | |||||
'GitHub. Repositories must be hosted on GitHub to be built with '. | 'GitHub. Repositories must be hosted on GitHub to be built with '. | ||||
'CircleCI.', | 'CircleCI.', | ||||
$commit_phid, | $commit_phid, | ||||
$repository_phid, | $repository_phid, | ||||
$remote_uri)); | $remote_uri)); | ||||
} | } | ||||
return $remote_uri; | return $remote_uri; | ||||
▲ Show 20 Lines • Show All 252 Lines • Show Last 20 Lines |
Maybe "...which has a remote URI..." would be slightly clearer than "...with an X with a Y...".