Differential D21624 Diff 51472 src/docs/contributor/contributing_code.diviner

Changeset View

Standalone View

src/docs/contributor/contributing_code.diviner

	Show First 20 Lines • Show All 206 Lines • ▼ Show 20 Lines
	with the project. This is not carte blanche, but distinguishing yourself can			with the project. This is not carte blanche, but distinguishing yourself can
	make us feel more comfortable about supporting a change which is slightly			make us feel more comfortable about supporting a change which is slightly
	outside of our comfort zone.			outside of our comfort zone.


	Writing and Submitting Patches			Writing and Submitting Patches
	==================			==================

	To actually submit a patch, run `arc diff` in `phabricator/`, `arcanist/`, or			To actually submit a patch, run `arc diff` in `phabricator/` or `arcanist/`.
	`libphutil/`. When executed in these directories, `arc` should automatically			When executed in these directories, `arc` should automatically talk to the
	talk to the upstream install. You can add `epriestley` as a reviewer.			upstream install. You can add `epriestley` as a reviewer.

	You should read the relevant coding convention documents before you submit a			You should read the relevant coding convention documents before you submit a
	change. If you're a new contributor, you don't need to worry about this too			change. If you're a new contributor, you don't need to worry about this too
	much. Just try to make your code look similar to the code around it, and we			much. Just try to make your code look similar to the code around it, and we
	can help you through the details during review.			can help you through the details during review.

	- @{article:General Coding Standards} (for all languages)			- @{article:General Coding Standards} (for all languages)
	- @{article:PHP Coding Standards} (for PHP)			- @{article:PHP Coding Standards} (for PHP)
	Show All 13 Lines