Differential D21186 Diff 50451 src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Changeset View

Standalone View

Show First 20 Lines • Show All 1,684 Lines • ▼ Show 20 Lines	private function getInterestingInlineStateChangeCounts() {
// present on older transactions.		// present on older transactions.
$details = $this->getMetadataValue('inline.details', array());		$details = $this->getMetadataValue('inline.details', array());

$new = $this->getNewValue();		$new = $this->getNewValue();

$done = 0;		$done = 0;
$undone = 0;		$undone = 0;
foreach ($new as $phid => $state) {		foreach ($new as $phid => $state) {
$is_done = ($state == PhabricatorInlineCommentInterface::STATE_DONE);		$is_done = ($state == PhabricatorInlineComment::STATE_DONE);

// See PHI995. If you're marking your own inline comments as "Done",		// See PHI995. If you're marking your own inline comments as "Done",
// don't count them when rendering a timeline story. In the case where		// don't count them when rendering a timeline story. In the case where
// you're only affecting your own comments, this will hide the		// you're only affecting your own comments, this will hide the
// "alice marked X comments as done" story entirely.		// "alice marked X comments as done" story entirely.

// Usually, this happens when you pre-mark inlines as "done" and submit		// Usually, this happens when you pre-mark inlines as "done" and submit
// them yourself. We'll still generate an "alice added inline comments"		// them yourself. We'll still generate an "alice added inline comments"
▲ Show 20 Lines • Show All 103 Lines • Show Last 20 Lines