Changeset View
Changeset View
Standalone View
Standalone View
src/runtime/ArcanistRuntime.php
| Show First 20 Lines • Show All 133 Lines • ▼ Show 20 Lines | private function executeCore(array $argv) { | ||||
| $args->setUnconsumedArgumentVector($result_argv); | $args->setUnconsumedArgumentVector($result_argv); | ||||
| // TOOLSETS: Some day, stop falling through to the old "arc" runtime. | // TOOLSETS: Some day, stop falling through to the old "arc" runtime. | ||||
| try { | try { | ||||
| return $args->parseWorkflowsFull($phutil_workflows); | return $args->parseWorkflowsFull($phutil_workflows); | ||||
| } catch (PhutilArgumentUsageException $usage_exception) { | } catch (PhutilArgumentUsageException $usage_exception) { | ||||
| // TODO: This is very, very hacky; we're trying to let errors like | |||||
Lint: TODO Comment: This comment has a TODO. | |||||
| // "you passed the wrong arguments" through but fall back to classic | |||||
| // mode if the workflow itself doesn't exist. | |||||
| if (!preg_match('/invalid command/i', $usage_exception->getMessage())) { | |||||
| throw $usage_exception; | |||||
| } | |||||
| $log->writeHint( | $log->writeHint( | ||||
| pht('(::)'), | pht('(::)'), | ||||
| pht( | pht( | ||||
| 'Workflow is unrecognized by modern "arc", falling through '. | 'Workflow is unrecognized by modern "arc", falling through '. | ||||
| 'to classic mode.')); | 'to classic mode.')); | ||||
| } | } | ||||
| $arcanist_root = phutil_get_library_root('arcanist'); | $arcanist_root = phutil_get_library_root('arcanist'); | ||||
| ▲ Show 20 Lines • Show All 494 Lines • Show Last 20 Lines | |||||
This comment has a TODO.