Differential D20552 Diff 49037 src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
| Show First 20 Lines • Show All 2,529 Lines • ▼ Show 20 Lines | protected function filterTransactions( | ||||
| if (!$no_effect) { | if (!$no_effect) { | ||||
| return $xactions; | return $xactions; | ||||
| } | } | ||||
| // If none of the transactions have an effect, the meta-transactions also | // If none of the transactions have an effect, the meta-transactions also | ||||
| // have no effect. Add them to the "no effect" list so we get a full set | // have no effect. Add them to the "no effect" list so we get a full set | ||||
| // of errors for everything. | // of errors for everything. | ||||
| if (!$any_effect) { | if (!$any_effect && !$has_comment) { | ||||
| $no_effect += $meta_xactions; | $no_effect += $meta_xactions; | ||||
| } | } | ||||
| if (!$this->getContinueOnNoEffect() && !$this->getIsPreview()) { | if (!$this->getContinueOnNoEffect() && !$this->getIsPreview()) { | ||||
| throw new PhabricatorApplicationTransactionNoEffectException( | throw new PhabricatorApplicationTransactionNoEffectException( | ||||
| $no_effect, | $no_effect, | ||||
| $any_effect, | $any_effect, | ||||
| $has_comment); | $has_comment); | ||||
| ▲ Show 20 Lines • Show All 2,803 Lines • Show Last 20 Lines | |||||