Changeset View
Changeset View
Standalone View
Standalone View
src/applications/diffusion/controller/DiffusionCommitController.php
| Show First 20 Lines • Show All 234 Lines • ▼ Show 20 Lines | if ($is_foreign) { | ||||
| } | } | ||||
| if (!$did_rewrite) { | if (!$did_rewrite) { | ||||
| $this->commitErrors[] = pht( | $this->commitErrors[] = pht( | ||||
| 'This commit has been deleted in the repository: it is no longer '. | 'This commit has been deleted in the repository: it is no longer '. | ||||
| 'reachable from any branch, tag, or ref.'); | 'reachable from any branch, tag, or ref.'); | ||||
| } | } | ||||
| } | } | ||||
| if (!$commit->isPermanentCommit()) { | |||||
| $nonpermanent_tag = id(new PHUITagView()) | |||||
| ->setType(PHUITagView::TYPE_SHADE) | |||||
| ->setName(pht('Not Permanent')) | |||||
| ->setColor(PHUITagView::COLOR_ORANGE); | |||||
| $header->addTag($nonpermanent_tag); | |||||
| $this->commitErrors[] = pht( | |||||
| 'This commit is not reachable from any permanent branch, tag, '. | |||||
amckinley: "Permanent" feels like a weird way to describe this, but I don't have any obviously-better… | |||||
| 'or ref.'); | |||||
| } | |||||
| if ($this->getCommitErrors()) { | if ($this->getCommitErrors()) { | ||||
| $error_panel = id(new PHUIInfoView()) | $error_panel = id(new PHUIInfoView()) | ||||
| ->appendChild($this->getCommitErrors()) | ->appendChild($this->getCommitErrors()) | ||||
| ->setSeverity(PHUIInfoView::SEVERITY_WARNING); | ->setSeverity(PHUIInfoView::SEVERITY_WARNING); | ||||
| } | } | ||||
| } | } | ||||
| ▲ Show 20 Lines • Show All 902 Lines • Show Last 20 Lines | |||||
"Permanent" feels like a weird way to describe this, but I don't have any obviously-better ideas. "Non-virtual"?