Differential D20288 Diff 48490 src/applications/project/trigger/PhabricatorProjectTriggerInvalidRule.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/project/trigger/PhabricatorProjectTriggerInvalidRule.php
- This file was added.
<?php | |||||
final class PhabricatorProjectTriggerInvalidRule | |||||
extends PhabricatorProjectTriggerRule { | |||||
const TRIGGERTYPE = 'invalid'; | |||||
public function getDescription() { | |||||
return pht( | |||||
'Invalid rule (of type "%s").', | |||||
$this->getRecord()->getType()); | |||||
amckinley: Maybe add a "valid values for rules of this type are..." blurb? | |||||
Done Inline ActionsThis is currently only used in the tooltip, so I didn't want to get a paragraph of text in. When the edit part happens, that should get more details. (This is going to have a Herald-style visual editor eventually, so it should be hard for users to specify invalid values -- really just extension/upgrade/manually-edit-the-db stuff.) epriestley: This is currently only used in the tooltip, so I didn't want to get a paragraph of text in. | |||||
} | |||||
protected function assertValidRuleValue($value) { | |||||
return; | |||||
} | |||||
protected function newDropTransactions($object, $value) { | |||||
return array(); | |||||
} | |||||
} |
Maybe add a "valid values for rules of this type are..." blurb?