Changeset View
Changeset View
Standalone View
Standalone View
webroot/rsrc/js/application/projects/WorkboardBoard.js
| Show First 20 Lines • Show All 489 Lines • ▼ Show 20 Lines | _onmovecard: function(list, item, after_node, src_list) { | ||||
| var item_phid = JX.Stratcom.getData(item).objectPHID; | var item_phid = JX.Stratcom.getData(item).objectPHID; | ||||
| var data = { | var data = { | ||||
| objectPHID: item_phid, | objectPHID: item_phid, | ||||
| columnPHID: dst_phid, | columnPHID: dst_phid, | ||||
| order: this.getOrder() | order: this.getOrder() | ||||
| }; | }; | ||||
| var context = this._getDropContext(after_node); | var context = this._getDropContext(after_node, item); | ||||
epriestley: This is a bugfix for a minor issue I introduced during recent refactoring. It could cause… | |||||
| if (context.afterPHID) { | if (context.afterPHID) { | ||||
| data.afterPHID = context.afterPHID; | data.afterPHID = context.afterPHID; | ||||
| } | } | ||||
| if (context.beforePHID) { | if (context.beforePHID) { | ||||
| data.beforePHID = context.beforePHID; | data.beforePHID = context.beforePHID; | ||||
| } | } | ||||
| ▲ Show 20 Lines • Show All 171 Lines • Show Last 20 Lines | |||||
This is a bugfix for a minor issue I introduced during recent refactoring. It could cause certain drops to the top of a column above valid cards to omit "beforePHIDs" and end up in a slightly-wrong place.