Differential D20259 Diff 48367 src/applications/harbormaster/herald/HarbormasterRunBuildPlansHeraldAction.php

Changeset View

Standalone View

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Lines	protected function getDatasource() {
return new HarbormasterBuildPlanDatasource();		return new HarbormasterBuildPlanDatasource();
}		}

public function renderActionDescription($value) {		public function renderActionDescription($value) {
return pht(		return pht(
'Run build plans: %s.',		'Run build plans: %s.',
$this->renderHandleList($value));		$this->renderHandleList($value));
}		}

		public function getPHIDsAffectedByAction(HeraldActionRecord $record) {
		return $record->getTarget();
		amckinleyUnsubmitted Not Done Inline Actions Should this be wrapped in an array? And also, why does the `HeraldActionRecord` typehint get highlighted differently here than the typehint in `HeraldAction.php`? amckinley: Should this be wrapped in an array? And also, why does the `HeraldActionRecord` typehint get…
		epriestleyAuthorUnsubmitted Done Inline Actions For this rule type, the target is already a list (since you can have a rule run more than one build plan). Colorization difference is an `xhpast` binary difference on some `secure` hosts, I think. epriestley: For this rule type, the target is already a list (since you can have a rule run more than one…
		}

}		}