Differential D20141 Diff 48109 src/applications/differential/controller/DifferentialRevisionViewController.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/differential/controller/DifferentialRevisionViewController.php
| Show First 20 Lines • Show All 1,092 Lines • ▼ Show 20 Lines | private function buildRawDiffResponse( | ||||
| $request_uri = $this->getRequest()->getRequestURI(); | $request_uri = $this->getRequest()->getRequestURI(); | ||||
| // this ends up being something like | // this ends up being something like | ||||
| // D123.diff | // D123.diff | ||||
| // or the verbose | // or the verbose | ||||
| // D123.vs123.id123.whitespaceignore-all.diff | // D123.vs123.id123.whitespaceignore-all.diff | ||||
| // lame but nice to include these options | // lame but nice to include these options | ||||
| $file_name = ltrim($request_uri->getPath(), '/').'.'; | $file_name = ltrim($request_uri->getPath(), '/').'.'; | ||||
| foreach ($request_uri->getQueryParams() as $key => $value) { | foreach ($request_uri->getQueryParamsAsPairList() as $pair) { | ||||
| list($key, $value) = $pair; | |||||
| if ($key == 'download') { | if ($key == 'download') { | ||||
| continue; | continue; | ||||
| } | } | ||||
| $file_name .= $key.$value.'.'; | $file_name .= $key.$value.'.'; | ||||
| } | } | ||||
epriestley: Changed "Whitespace" option in Differential, then clicked "Download Raw Diff". Saw URI reflect… | |||||
| $file_name .= 'diff'; | $file_name .= 'diff'; | ||||
| $unguarded = AphrontWriteGuard::beginScopedUnguardedWrites(); | $unguarded = AphrontWriteGuard::beginScopedUnguardedWrites(); | ||||
| $file = PhabricatorFile::newFromFileData( | $file = PhabricatorFile::newFromFileData( | ||||
| $raw_diff, | $raw_diff, | ||||
| array( | array( | ||||
| 'name' => $file_name, | 'name' => $file_name, | ||||
| 'ttl.relative' => phutil_units('24 hours in seconds'), | 'ttl.relative' => phutil_units('24 hours in seconds'), | ||||
| ▲ Show 20 Lines • Show All 341 Lines • Show Last 20 Lines | |||||
Changed "Whitespace" option in Differential, then clicked "Download Raw Diff". Saw URI reflect whitespace change.