Differential D20131 Diff 48068 src/applications/transactions/view/PhabricatorApplicationTransactionView.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
| Show First 20 Lines • Show All 410 Lines • ▼ Show 20 Lines | $event = id(new PHUITimelineEventView()) | ||||
| ->setViewer($viewer) | ->setViewer($viewer) | ||||
| ->setAuthorPHID($xaction->getAuthorPHID()) | ->setAuthorPHID($xaction->getAuthorPHID()) | ||||
| ->setTransactionPHID($xaction->getPHID()) | ->setTransactionPHID($xaction->getPHID()) | ||||
| ->setUserHandle($xaction->getHandle($xaction->getAuthorPHID())) | ->setUserHandle($xaction->getHandle($xaction->getAuthorPHID())) | ||||
| ->setIcon($xaction->getIcon()) | ->setIcon($xaction->getIcon()) | ||||
| ->setColor($xaction->getColor()) | ->setColor($xaction->getColor()) | ||||
| ->setHideCommentOptions($this->getHideCommentOptions()) | ->setHideCommentOptions($this->getHideCommentOptions()) | ||||
| ->setIsSilent($xaction->getIsSilentTransaction()) | ->setIsSilent($xaction->getIsSilentTransaction()) | ||||
| ->setIsMFA($xaction->getIsMFATransaction()); | ->setIsMFA($xaction->getIsMFATransaction()) | ||||
| ->setIsLockOverride($lock = $xaction->getIsLockOverrideTransaction()); | |||||
amckinley: I'm pretty sure this was not what you meant, since `$lock` isn't used again in this function… | |||||
| list($token, $token_removed) = $xaction->getToken(); | list($token, $token_removed) = $xaction->getToken(); | ||||
| if ($token) { | if ($token) { | ||||
| $event->setToken($token, $token_removed); | $event->setToken($token, $token_removed); | ||||
| } | } | ||||
| if (!$this->shouldSuppressTitle($xaction, $group)) { | if (!$this->shouldSuppressTitle($xaction, $group)) { | ||||
| if ($this->renderAsFeed) { | if ($this->renderAsFeed) { | ||||
| ▲ Show 20 Lines • Show All 114 Lines • Show Last 20 Lines | |||||
I'm pretty sure this was not what you meant, since $lock isn't used again in this function and I've never seen the "use assignment operation's side effect as a function argument" idiom in the Phabricator code base.