Differential D20078 Diff 47948 src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/repository/management/PhabricatorRepositoryManagementWorkflow.php
<?php | <?php | ||||
abstract class PhabricatorRepositoryManagementWorkflow | abstract class PhabricatorRepositoryManagementWorkflow | ||||
extends PhabricatorManagementWorkflow { | extends PhabricatorManagementWorkflow { | ||||
protected function loadRepositories(PhutilArgumentParser $args, $param) { | protected function loadRepositories(PhutilArgumentParser $args, $param) { | ||||
$identifiers = $args->getArg($param); | $identifiers = $args->getArg($param); | ||||
if (!$identifiers) { | if (!$identifiers) { | ||||
return null; | return array(); | ||||
epriestley: This is a fix for PHP 7.3+ complaining about `count(null)` when you run `bin/repository update`… | |||||
} | } | ||||
$query = id(new PhabricatorRepositoryQuery()) | $query = id(new PhabricatorRepositoryQuery()) | ||||
->setViewer($this->getViewer()) | ->setViewer($this->getViewer()) | ||||
->needURIs(true) | ->needURIs(true) | ||||
->withIdentifiers($identifiers); | ->withIdentifiers($identifiers); | ||||
$query->execute(); | $query->execute(); | ||||
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines |
This is a fix for PHP 7.3+ complaining about count(null) when you run bin/repository update with no arguments.