Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Differential
D19988
Diff 47736
src/applications/metamta/message/PhabricatorPhoneNumber.php
Changeset View
I have no idea what the implications are for storing phone numbers as a bag of digits vs having distinct countryCode, exchange, lastCoupleDigits, etc, fields. I feel reasonably good about always adding a US prefix for numbers that don't specify it, though. Obviously in the future this should use your time zone preference to infer the correct country code on the fly.
Have you read any of the E.164 spec, or heard any war stories about normalizing phone numbers? What we're doing here all seems reasonable to me, but I can imagine a horrible future where Phabricator needs to make phone calls to users who live in the distant past and we need to store phone numbers like PEnnsylvania 6-5000 or whatever.