Differential D19988 Diff 47736 src/applications/metamta/message/PhabricatorPhoneNumber.php

Changeset View

Standalone View

src/applications/metamta/message/PhabricatorPhoneNumber.php

	<?php			<?php

	final class PhabricatorPhoneNumber			final class PhabricatorPhoneNumber
	extends Phobject {			extends Phobject {

	private $number;			private $number;

	public function __construct($raw_number) {			public function __construct($raw_number) {
	$number = preg_replace('/[^\d]+/', '', $raw_number);			$number = preg_replace('/[^\d]+/', '', $raw_number);

	if (!preg_match('/^[1-9]\d{1,14}\z/', $number)) {			if (!preg_match('/^[1-9]\d{9,14}\z/', $number)) {
	throw new Exception(			throw new Exception(
	pht(			pht(
	'Phone number ("%s") is not in a recognized format.',			'Phone number ("%s") is not in a recognized format: expected a '.
				'US number like "(555) 555-5555", or an international number '.
				'like "+55 5555 555555".',
	$raw_number));			$raw_number));
	}			}

				// If the number didn't start with "+" and has has 10 digits, assume it is
				// a US number with no country code prefix, like "(555) 555-5555".
				if (!preg_match('/^[+]/', $raw_number)) {
				if (strlen($number) === 10) {
				$number = '1'.$number;
				}
				}
				amckinleyUnsubmitted Not Done Inline Actions I have no idea what the implications are for storing phone numbers as a bag of digits vs having distinct `countryCode`, `exchange`, `lastCoupleDigits`, etc, fields. I feel reasonably good about always adding a US prefix for numbers that don't specify it, though. Obviously in the future this should use your time zone preference to infer the correct country code on the fly. Have you read any of the E.164 spec, or heard any war stories about normalizing phone numbers? What we're doing here all seems reasonable to me, but I can imagine a horrible future where Phabricator needs to make phone calls to users who live in the distant past and we need to store phone numbers like PEnnsylvania 6-5000 or whatever. amckinley: I have no idea what the implications are for storing phone numbers as a bag of digits vs having…

	$this->number = $number;			$this->number = $number;
	}			}

	public function toE164() {			public function toE164() {
	return '+'.$this->number;			return '+'.$this->number;
	}			}

	}			}