Changeset View
Changeset View
Standalone View
Standalone View
src/view/AphrontDialogView.php
| Show First 20 Lines • Show All 398 Lines • ▼ Show 20 Lines | $content = array( | ||||
| phutil_tag( | phutil_tag( | ||||
| 'div', | 'div', | ||||
| array( | array( | ||||
| 'class' => 'aphront-dialog-head', | 'class' => 'aphront-dialog-head', | ||||
| ), | ), | ||||
| $header), | $header), | ||||
| phutil_tag('div', | phutil_tag('div', | ||||
| array( | array( | ||||
| 'class' => 'aphront-dialog-body phabricator-remarkup grouped', | 'class' => 'aphront-dialog-body grouped', | ||||
epriestley: The `phabricator-remarkup` rule has some side effects with margins that prevented the list of… | |||||
| ), | ), | ||||
| $children), | $children), | ||||
| $tail, | $tail, | ||||
| ); | ); | ||||
| if ($this->renderAsForm) { | if ($this->renderAsForm) { | ||||
| return phabricator_form( | return phabricator_form( | ||||
| $this->getViewer(), | $this->getViewer(), | ||||
| Show All 20 Lines | |||||
The phabricator-remarkup rule has some side effects with margins that prevented the list of options from laying out properly.
This change removes phabricator-remarkup from the body of all dialogs. It's possible this will do some weird things.
I couldn't find any weird things based on prodding it for a bit. When we add remarkup to dialogs, it is normally added inside its own container. I think this was just a legacy thing and that collateral damage will be minor or nonexistent, but this might need some amount of cleanup. In any case, removing this class is clearly more "correct" from a purity standpoint, since dialog bodies are often not remarkup.