Differential D19852 Diff 47411 src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php
Changeset View
Changeset View
Standalone View
Standalone View
src/applications/transactions/editor/PhabricatorEditEngineConfigurationEditor.php
| Show First 20 Lines • Show All 58 Lines • ▼ Show 20 Lines | switch ($type) { | ||||
| case PhabricatorEditEngineConfigurationTransaction::TYPE_SUBTYPE: | case PhabricatorEditEngineConfigurationTransaction::TYPE_SUBTYPE: | ||||
| if ($xactions) { | if ($xactions) { | ||||
| $map = $object->getEngine() | $map = $object->getEngine() | ||||
| ->setViewer($this->getActor()) | ->setViewer($this->getActor()) | ||||
| ->newSubtypeMap(); | ->newSubtypeMap(); | ||||
| foreach ($xactions as $xaction) { | foreach ($xactions as $xaction) { | ||||
| $new = $xaction->getNewValue(); | $new = $xaction->getNewValue(); | ||||
| if (isset($map[$new])) { | if ($map->isValidSubtype($new)) { | ||||
| continue; | continue; | ||||
| } | } | ||||
| $errors[] = new PhabricatorApplicationTransactionValidationError( | $errors[] = new PhabricatorApplicationTransactionValidationError( | ||||
| $type, | $type, | ||||
| pht('Invalid'), | pht('Invalid'), | ||||
| pht('Subtype "%s" is not a valid subtype.', $new), | pht('Subtype "%s" is not a valid subtype.', $new), | ||||
| $xaction); | $xaction); | ||||
| ▲ Show 20 Lines • Show All 128 Lines • Show Last 20 Lines | |||||