Differential D19765 Diff 47235 src/infrastructure/storage/__tests__/QueryFormattingTestCase.php

Changeset View

Standalone View

src/infrastructure/storage/tests/QueryFormattingTestCase.php

	<?php			<?php

	final class QueryFormattingTestCase extends PhabricatorTestCase {			final class QueryFormattingTestCase extends PhabricatorTestCase {

	public function testQueryFormatting() {			public function testQueryFormatting() {
	$conn_r = id(new PhabricatorUser())->establishConnection('r');			$conn = id(new PhabricatorUser())->establishConnection('r');

	$this->assertEqual(			$this->assertEqual(
	'NULL',			'NULL',
	qsprintf($conn_r, '%nd', null));			qsprintf($conn, '%nd', null));

	$this->assertEqual(			$this->assertEqual(
	'0',			'0',
	qsprintf($conn_r, '%nd', 0));			qsprintf($conn, '%nd', 0));

	$this->assertEqual(			$this->assertEqual(
	'0',			'0',
	qsprintf($conn_r, '%d', 0));			qsprintf($conn, '%d', 0));

	$raised = null;			$raised = null;
	try {			try {
	qsprintf($conn_r, '%d', 'derp');			qsprintf($conn, '%d', 'derp');
	} catch (Exception $ex) {			} catch (Exception $ex) {
	$raised = $ex;			$raised = $ex;
	}			}
	$this->assertTrue(			$this->assertTrue(
	(bool)$raised,			(bool)$raised,
	pht('%s should raise exception for invalid %%d conversion.', 'qsprintf'));			pht('%s should raise exception for invalid %%d conversion.', 'qsprintf'));

	$this->assertEqual(			$this->assertEqual(
	"'<S>'",			"'<S>'",
	qsprintf($conn_r, '%s', null));			qsprintf($conn, '%s', null));

	$this->assertEqual(			$this->assertEqual(
	'NULL',			'NULL',
	qsprintf($conn_r, '%ns', null));			qsprintf($conn, '%ns', null));

	$this->assertEqual(			$this->assertEqual(
	"'<S>', '<S>'",			"'<S>', '<S>'",
	qsprintf($conn_r, '%Ls', array('x', 'y')));			qsprintf($conn, '%Ls', array('x', 'y')));

	$this->assertEqual(			$this->assertEqual(
	"'<B>'",			"'<B>'",
	qsprintf($conn_r, '%B', null));			qsprintf($conn, '%B', null));

	$this->assertEqual(			$this->assertEqual(
	'NULL',			'NULL',
	qsprintf($conn_r, '%nB', null));			qsprintf($conn, '%nB', null));

	$this->assertEqual(			$this->assertEqual(
	"'<B>', '<B>'",			"'<B>', '<B>'",
	qsprintf($conn_r, '%LB', array('x', 'y')));			qsprintf($conn, '%LB', array('x', 'y')));

				$this->assertEqual(
				'<C>',
				qsprintf($conn, '%T', 'x'));

				$this->assertEqual(
				'<C>',
				qsprintf($conn, '%C', 'y'));

				$this->assertEqual(
				'<C>.<C>',
				qsprintf($conn, '%R', new AphrontDatabaseTableRef('x', 'y')));
				amckinleyUnsubmitted Not Done Inline Actions I'm not sure how to read these test definitions. I was looking around for `QueryFormattingTestCase` to redefine `assertEqual`, since it doesn't make a lot of sense to me that `qsprintf` would actually return strings like `'<C>.<C>'`. Can you give me some insight? amckinley: I'm not sure how to read these test definitions. I was looking around for…

	}			}


	}			}