Differential D19695 Diff 47069 src/toolset/ArcanistWorkflow.php

Changeset View

Standalone View

src/toolset/ArcanistWorkflow.php

<?php		<?php

abstract class ArcanistWorkflow extends Phobject {		abstract class ArcanistWorkflow extends Phobject {

private $toolset;		private $toolset;
private $arguments;		private $arguments;
		private $configurationEngine;
		private $configurationSourceList;

/**		/**
* Return the command used to invoke this workflow from the command like,		* Return the command used to invoke this workflow from the command like,
* e.g. "help" for @{class:ArcanistHelpWorkflow}.		* e.g. "help" for @{class:ArcanistHelpWorkflow}.
*		*
* @return string The command a user types to invoke this workflow.		* @return string The command a user types to invoke this workflow.
*/		*/
abstract public function getWorkflowName();		abstract public function getWorkflowName();
Show All 30 Lines	final public function getToolset() {
return $this->toolset;		return $this->toolset;
}		}

final public function setToolset(ArcanistToolset $toolset) {		final public function setToolset(ArcanistToolset $toolset) {
$this->toolset = $toolset;		$this->toolset = $toolset;
return $this;		return $this;
}		}

		final public function setConfigurationSourceList(
		ArcanistConfigurationSourceList $config) {
		$this->configurationSourceList = $config;
		return $this;
		}

		final public function getConfigurationSourceList() {
		return $this->configurationSourceList;
		}

		final public function setConfigurationEngine(
		ArcanistConfigurationEngine $configuration_engine) {
		$this->configurationEngine = $configuration_engine;
		return $this;
		}

		final public function getConfigurationEngine() {
		return $this->configurationEngine;
		}
		amckinleyUnsubmitted Not Done Inline Actions I'm assuming this looks commented-out because of the same spooky syntax highlighting behavior I noticed the other day. amckinley: I'm assuming this looks commented-out because of the same spooky syntax highlighting behavior I…
		epriestleyAuthorUnsubmitted Done Inline Actions This one is slightly different: the syntax highlighter is given an entire "reconstructed" file, not a series of snippets. So it sees: /** <...50 blank lines where the context is missing...> return $this->... ...and concludes "oh you have a real big unterminated multi-line comment there". We can't ever get this right in the general case (we'll often be missing the start or end of multiline comments if we're missing context) although I think there's a reasonable argument that we'd get it right more often if we highlighted each block separately. In practice, as long as you use `arc` this isn't really an issue. epriestley: This one is slightly different: the syntax highlighter is given an entire "reconstructed" file…

final protected function getToolsetKey() {		final protected function getToolsetKey() {
return $this->getToolset()->getToolsetKey();		return $this->getToolset()->getToolsetKey();
}		}

final public function executeWorkflow(PhutilArgumentParser $args) {		final public function executeWorkflow(PhutilArgumentParser $args) {
$this->arguments = $args;		$this->arguments = $args;
$caught = null;		$caught = null;

Show All 27 Lines