Page MenuHomePhabricator
Differential D19541 Diff 46728 src/applications/differential/controller/DifferentialRevisionViewController.php

Changeset View

Standalone View

View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

<?php <?php
final class DifferentialRevisionViewController final class DifferentialRevisionViewController
extends DifferentialController { extends DifferentialController {
private $revisionID; private $revisionID;
private $changesetCount; private $changesetCount;
private $hiddenChangesets; private $hiddenChangesets;
private $warnings = array();
public function shouldAllowPublic() { public function shouldAllowPublic() {
return true; return true;
} }
public function isLargeDiff() { public function isLargeDiff() {
return ($this->getChangesetCount() > $this->getLargeDiffLimit()); return ($this->getChangesetCount() > $this->getLargeDiffLimit());
} }
▲ Show 20 Lines • Show All 46 Lines • ▼ Show 20 Lines public function handleRequest(AphrontRequest $request) {
if (!$diffs) { if (!$diffs) {
throw new Exception( throw new Exception(
pht('This revision has no diffs. Something has gone quite wrong.')); pht('This revision has no diffs. Something has gone quite wrong.'));
} }
$revision->attachActiveDiff(last($diffs)); $revision->attachActiveDiff(last($diffs));
$diff_vs = $request->getInt('vs'); $diff_vs = $this->getOldDiffID($revision, $diffs);
$target_id = $request->getInt('id'); if ($diff_vs instanceof AphrontResponse) {
$target = idx($diffs, $target_id, end($diffs)); return $diff_vs;
}
$target_id = $this->getNewDiffID($revision, $diffs);
if ($target_id instanceof AphrontResponse) {
return $target_id;
}
$target = $diffs[$target_id];
$target_manual = $target; $target_manual = $target;
if (!$target_id) { if (!$target_id) {
foreach ($diffs as $diff) { foreach ($diffs as $diff) {
if ($diff->getCreationMethod() != 'commit') { if ($diff->getCreationMethod() != 'commit') {
$target_manual = $diff; $target_manual = $diff;
} }
} }
} }
if (empty($diffs[$diff_vs])) {
$diff_vs = null;
}
$repository = null; $repository = null;
$repository_phid = $target->getRepositoryPHID(); $repository_phid = $target->getRepositoryPHID();
if ($repository_phid) { if ($repository_phid) {
if ($repository_phid == $revision->getRepositoryPHID()) { if ($repository_phid == $revision->getRepositoryPHID()) {
$repository = $revision->getRepository(); $repository = $revision->getRepository();
} else { } else {
$repository = id(new PhabricatorRepositoryQuery()) $repository = id(new PhabricatorRepositoryQuery())
->setViewer($viewer) ->setViewer($viewer)
▲ Show 20 Lines • Show All 69 Lines • ▼ Show 20 Lines foreach ($field_list->getFields() as $key => $field) {
$req = $field->getRequiredHandlePHIDsForRevisionHeaderWarnings(); $req = $field->getRequiredHandlePHIDsForRevisionHeaderWarnings();
foreach ($req as $phid) { foreach ($req as $phid) {
$warning_handle_map[$key][] = $phid; $warning_handle_map[$key][] = $phid;
$object_phids[] = $phid; $object_phids[] = $phid;
} }
} }
$handles = $this->loadViewerHandles($object_phids); $handles = $this->loadViewerHandles($object_phids);
$warnings = array(); $warnings = $this->warnings;
$request_uri = $request->getRequestURI(); $request_uri = $request->getRequestURI();
$large = $request->getStr('large'); $large = $request->getStr('large');
$large_warning = $large_warning =
($this->isLargeDiff()) && ($this->isLargeDiff()) &&
(!$this->isVeryLargeDiff()) && (!$this->isVeryLargeDiff()) &&
▲ Show 20 Lines • Show All 1,125 Lines • ▼ Show 20 Lines return id(new HarbormasterUnitSummaryView())
->setUser($viewer) ->setUser($viewer)
->setExcuse($excuse) ->setExcuse($excuse)
->setBuildable($diff->getBuildable()) ->setBuildable($diff->getBuildable())
->setUnitMessages($diff->getUnitMessages()) ->setUnitMessages($diff->getUnitMessages())
->setLimit(5) ->setLimit(5)
->setShowViewAll(true); ->setShowViewAll(true);
} }
private function getOldDiffID(DifferentialRevision $revision, array $diffs) {
assert_instances_of($diffs, 'DifferentialDiff');
$request = $this->getRequest();
$diffs = mpull($diffs, null, 'getID');
$is_new = ($request->getURIData('filter') === 'new');
$old_id = $request->getInt('vs');
// This is ambiguous, so just 404 rather than trying to figure out what
// the user expects.
if ($is_new && $old_id) {
return new Aphront404Response();
}
if ($is_new) {
$viewer = $this->getViewer();
$xactions = id(new DifferentialTransactionQuery())
->setViewer($viewer)
->withObjectPHIDs(array($revision->getPHID()))
->withAuthorPHIDs(array($viewer->getPHID()))
->setOrder('newest')
->setLimit(1)
->execute();
if (!$xactions) {
$this->warnings[] = id(new PHUIInfoView())
->setTitle(pht('No Actions'))
->setSeverity(PHUIInfoView::SEVERITY_WARNING)
->appendChild(
pht(
'Showing all changes because you have never taken an '.
'action on this revision.'));
} else {
$xaction = head($xactions);
// Find the transactions which updated this revision. We want to
// figure out which diff was active when you last took an action.
$updates = id(new DifferentialTransactionQuery())
->setViewer($viewer)
->withObjectPHIDs(array($revision->getPHID()))
->withTransactionTypes(
array(
DifferentialRevisionUpdateTransaction::TRANSACTIONTYPE,
))
->setOrder('oldest')
->execute();
// Sort the diffs into two buckets: those older than your last action
// and those newer than your last action.
$older = array();
$newer = array();
foreach ($updates as $update) {
// If you updated the revision with "arc diff", try to count that
// update as "before your last action".
if ($update->getDateCreated() <= $xaction->getDateCreated()) {
$older[] = $update->getNewValue();
} else {
$newer[] = $update->getNewValue();
}
}
if (!$newer) {
$this->warnings[] = id(new PHUIInfoView())
->setTitle(pht('No Recent Updates'))
->setSeverity(PHUIInfoView::SEVERITY_WARNING)
->appendChild(
pht(
'Showing all changes because the diff for this revision '.
'has not been updated since your last action.'));
} else {
$older = array_fuse($older);
// Find the most recent diff from before the last action.
$old = null;
foreach ($diffs as $diff) {
if (!isset($older[$diff->getPHID()])) {
break;
}
$old = $diff;
}
// It's possible we may not find such a diff: transactions may have
// been removed from the database, for example. If we miss, just
// fail into some reasonable state since 404'ing would be perplexing.
if ($old) {
$this->warnings[] = id(new PHUIInfoView())
->setTitle(pht('New Changes Shown'))
->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
->appendChild(
pht(
'Showing changes since the last action you took on this '.
'revision.'));
$old_id = $old->getID();
}
}
}
}
if (isset($diffs[$old_id])) {
return $old_id;
}
return null;
}
private function getNewDiffID(DifferentialRevision $revision, array $diffs) {
assert_instances_of($diffs, 'DifferentialDiff');
$request = $this->getRequest();
$diffs = mpull($diffs, null, 'getID');
$is_new = ($request->getURIData('filter') === 'new');
$new_id = $request->getInt('id');
if ($is_new && $new_id) {
return new Aphront404Response();
}
if (isset($diffs[$new_id])) {
return $new_id;
}
return (int)last_key($diffs);
}
} }
Phabricator · Built by Phacility