Changeset View
Changeset View
Standalone View
Standalone View
src/applications/people/editor/PhabricatorUserEditor.php
| Show First 20 Lines • Show All 414 Lines • ▼ Show 20 Lines | $user->openTransaction(); | ||||
| $user->getPHID(), | $user->getPHID(), | ||||
| PhabricatorUserLog::ACTION_EMAIL_ADD); | PhabricatorUserLog::ACTION_EMAIL_ADD); | ||||
| $log->setNewValue($email->getAddress()); | $log->setNewValue($email->getAddress()); | ||||
| $log->save(); | $log->save(); | ||||
| $user->endWriteLocking(); | $user->endWriteLocking(); | ||||
| $user->saveTransaction(); | $user->saveTransaction(); | ||||
| // Try and match this new address against unclaimed `RepositoryIdentity`s | |||||
| PhabricatorWorker::scheduleTask( | |||||
| 'PhabricatorRepositoryIdentityChangeWorker', | |||||
| array('userPHID' => $user->getPHID()), | |||||
epriestley: Ideally, pass the user PHID as the `objectPHID` in the third parameter too -- I think like this… | |||||
| array('objectPHID' => $user->getPHID())); | |||||
| return $this; | return $this; | ||||
| } | } | ||||
| /** | /** | ||||
| * @task email | * @task email | ||||
| */ | */ | ||||
| public function removeEmail( | public function removeEmail( | ||||
| ▲ Show 20 Lines • Show All 289 Lines • Show Last 20 Lines | |||||
Ideally, pass the user PHID as the objectPHID in the third parameter too -- I think like this:
That makes it a little easier to hunt down tasks by querying the table in some unusual cases, since we can find tasks "about object X" by querying on this column, but it tends to be a mess to try to find tasks by LIKE'ing the JSON blob.